Skip to content

Backport #752 to 0.29.x #753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 18, 2024
Merged

Backport #752 to 0.29.x #753

merged 2 commits into from
Oct 18, 2024

Conversation

@shinghim
Copy link
Contributor

@shinghim shinghim commented Oct 17, 2024 •
edited by apoelstra
Loading 

          Also, we should consider backporting this to the version used by rust-bitcoin 0.32.

Originally posted by apoelstra in #752 (comment)

Backport #752 to the version used by rust-bitcoin 0.32

@shinghim
Create Party enum
33fda15 
Introducing this enum as a replacement for ElligatorSwiftParty. Party is
more descriptive and should cause less confusion than
ElligatorSwiftParty
@shinghim shinghim changed the title Backport elligator Backport #752 to 0.29.x Oct 17, 2024
@shinghim
Copy link
Contributor Author

I see the last few commits are failing the same 3 CI checks. Do those need fixing before more get merged in?

@shinghim shinghim marked this pull request as ready for review October 17, 2024 23:49
tcharding
tcharding approved these changes Oct 18, 2024
View reviewed changes
Copy link
Member

@tcharding tcharding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The docs indentation CI failure we can definitely ignore, I re-ran all failing jobs because I didn't understand the cross failure.

@apoelstra
Copy link
Member

I suspect the cross failures are due to #735 which we could also backport

apoelstra
apoelstra approved these changes Oct 18, 2024
View reviewed changes
Copy link
Member

@apoelstra apoelstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK f12bde6; successfully ran local tests

@apoelstra apoelstra merged commit 3c95e1d into rust-bitcoin:0.29.x Oct 18, 2024
17 of 21 checks passed
@shinghim shinghim deleted the backport-elligator branch October 19, 2024 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@apoelstra apoelstra apoelstra approved these changes

@tcharding tcharding tcharding approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@shinghim @apoelstra @tcharding